generate TOC without custom jekyll plugin #25838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like I have said numerous times, I'd rather not do this. Using GitHub pages is useless in our case. |
|
This is your opinion, with a project with 60k forks and a maintainer working at github this responsibility may be different. The goal should be to make the setup easy for each contributor, no matter if html beginner, dev expert or theme designer. github pages helps to visualize quick results with a easy setup. This is a request and was just easy to achieve, I've wanted to point this out. ✌️ |
|
Again, it's not my point of view; it's how we use GitHub pages. We have the old docs there too, which aren't present in the branch here. Anyway, I give up on this. To me, all this is futile. Nor have you pasted any numbers from all these changes, positive or negative. Off to @mdo. |
|
📊 Jekyll's build-in Liquid profiler generates: Sadly, custom plugins are not detailed listed. I could only compare the total build time: jekyll-doc branch –
|
XhmikosR
reviewed
Mar 21, 2018
XhmikosR
reviewed
Mar 21, 2018
m5o
force-pushed
the
jekyll-toc
branch
2 times, most recently
from
3eb4c81 to
d897122
Compare
|
Hey @mdo 👋 Are you interested in this change? Just asking, if it's worth the work to keep it up-to-date with |
m5o
force-pushed
the
jekyll-toc
branch
2 times, most recently
from
9c7e907 to
fe68d72
Compare
|
@mdo: what do you want to do with this one? |
|
@XhmikosR Seems like we should close this one given your ToC work? |
|
Let's leave this open for now. It'll be moot anyway with Hugo. |
m5o
force-pushed
the
jekyll-toc
branch
2 times, most recently
from
6cabb70 to
03bc0d5
Compare
* remove toshimaru/jekyll-toc gem
* use h5 and h6 headlines inside callouts * h5 and h6 by default are excluded by toc generation
* possibly added by false resolving a merge conflict
|
Closing this since we are going to switch to Hugo. Thanks for the patch though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toshimaru/jekyll-tocI've checked generation of every site, it works like a charm 👌
This is the final 🏁 PR wich removes custom plugins from
bootstrap docs and enable first-class support for github-pages 🙌
🔗 #25784
🔗 #25319
🔗 #25320
Hope you like it. 🖖
/cc @allejo