-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTMLHint to the build #20301
Add HTMLHint to the build #20301
Conversation
[skip sauce]
@@ -327,7 +330,7 @@ module.exports = function (grunt) { | |||
require('time-grunt')(grunt); | |||
|
|||
// Docs HTML validation task | |||
grunt.registerTask('validate-html', ['jekyll:docs', 'htmllint']); | |||
grunt.registerTask('validate-html', ['jekyll:docs', 'htmllint', 'exec:htmlhint']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra semicolon semi
What happened to grunt-html? Unless there's a good reason, I'm not in favor of this. grunt-html is kept up to date with the latest vnu.jar markup, which is the standard tool for this job. |
This is in addition to grunt-html, not as a replacement. |
Oh, OK. In that case I guess it's OK. Is the config you used strict enough? |
👍 |
Strict enough for what? I enabled every available rule that looked appropriate for us. |
OK if you think it's what we need. I didn't go through all options myself On Jul 14, 2016 22:41, "Chris Rebert" notifications@github.com wrote:
|
@cvrebert Did you notice any changes/improvements since you added HTMLHint? |
No, since we already complied with it after your PR. |
Fixes #20297.
CC: @XhmikosR @hnrch02