Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLHint to the build #20301

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Add HTMLHint to the build #20301

merged 1 commit into from
Jul 14, 2016

Conversation

cvrebert
Copy link
Collaborator

@@ -327,7 +330,7 @@ module.exports = function (grunt) {
require('time-grunt')(grunt);

// Docs HTML validation task
grunt.registerTask('validate-html', ['jekyll:docs', 'htmllint']);
grunt.registerTask('validate-html', ['jekyll:docs', 'htmllint', 'exec:htmlhint']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra semicolon semi

@XhmikosR
Copy link
Member

XhmikosR commented Jul 14, 2016

What happened to grunt-html? Unless there's a good reason, I'm not in favor of this. grunt-html is kept up to date with the latest vnu.jar markup, which is the standard tool for this job.

@cvrebert
Copy link
Collaborator Author

This is in addition to grunt-html, not as a replacement.

@XhmikosR
Copy link
Member

Oh, OK. In that case I guess it's OK.

Is the config you used strict enough?

@hnrch02
Copy link
Collaborator

hnrch02 commented Jul 14, 2016

👍

@cvrebert
Copy link
Collaborator Author

Is the config you used strict enough?

Strict enough for what?

I enabled every available rule that looked appropriate for us.

@XhmikosR
Copy link
Member

OK if you think it's what we need. I didn't go through all options myself
that's why I asked.

On Jul 14, 2016 22:41, "Chris Rebert" notifications@github.com wrote:

Is the config you used strict enough?

Strict enough for what?

I enabled every available rule that looked appropriate for us.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20301 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAVVteP_PKejXoFr891C5GiuRbyTo1o_ks5qVpDOgaJpZM4JMKhL
.

@cvrebert cvrebert merged commit 0cf5204 into v4-dev Jul 14, 2016
@cvrebert cvrebert deleted the fix-20297 branch July 14, 2016 23:23
@tomlutzenberger
Copy link
Contributor

@cvrebert Did you notice any changes/improvements since you added HTMLHint?

@cvrebert
Copy link
Collaborator Author

No, since we already complied with it after your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants