Replace grunt-postcss with postcss-cli #20140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't yet implement the standard PostCSS plugin interface.
Refs #19990 Continues the degruntification process.
| } | ||
| } | ||
| @else { | ||
| // TODO: re-enable along with mq4-hover-shim |
There was a problem hiding this comment.
Would you add this back in a separate PR or was this an oversight?
There was a problem hiding this comment.
Separate PR. Would need to first change mq4-hover-shim to implement PostCSS's standard plugin API.
Also depends on the answer to #19968 (comment)
There was a problem hiding this comment.
What's the issue tracking this so I can subscribe? Cheers.
|
Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #19990.
CC: @XhmikosR @hnrch02