Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round results from gutter division to prevent decimal margins and padding #16351

Merged
merged 1 commit into from
Apr 26, 2015
Merged

Round results from gutter division to prevent decimal margins and padding #16351

merged 1 commit into from
Apr 26, 2015

Conversation

thomasphorton
Copy link
Contributor

Fixes #16281

left rounds up, right rounds down. should keep everything playing nice.

@cvrebert cvrebert added the css label Apr 24, 2015
@mdo
Copy link
Member

mdo commented Apr 25, 2015

Nice, I think this should be good to go. The default code doesn't change obviously, and it should handle that half pixel problem nicely.

@mdo mdo added this to the v3.3.5 milestone Apr 25, 2015
mdo added a commit that referenced this pull request Apr 26, 2015
Round results from gutter division to prevent decimal margins and padding
@mdo mdo merged commit 2b1c06f into twbs:master Apr 26, 2015
@cvrebert cvrebert mentioned this pull request Apr 26, 2015
@kminek
Copy link

kminek commented Aug 5, 2015

this change breaks computing for non-px values. suppose i would like to use only grids from bs and set @grid-gutter-width: 3em - i would expect 1.5em value should be set on both sides - currently it's not :(

@thomasphorton
Copy link
Contributor Author

What behavior do you see? Does one go to 1 and the other 2?

That's a big oversight on my part. If you give me some more information I'll look into a fix.

@zacechola
Copy link

Open up a new issue, @kminek.

@mdo
Copy link
Member

mdo commented Aug 5, 2015

Yeah, that's a valid concern. If that's the case, I'm actually in favor of removing any and all rounding for the grid. We've gotten by for nearly two years without it, we can stick it out until v4 :).

@kminek
Copy link

kminek commented Aug 5, 2015

i would also remove rounding and take approach suggested in #16281 - that is to introduce optional variables for left-/right-gutter-part :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid gutter issue with uneven pixel values
5 participants