Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme - Cleanup (btn-default) #15406

Closed
wants to merge 1 commit into from
Closed

Conversation

Ninos
Copy link

@Ninos Ninos commented Dec 19, 2014

border-color is not nessessary. The color will be defined in the https://github.com/twbs/bootstrap/blob/master/less/buttons.less#L60.

.btn-default {
  .button-variant(@btn-default-color; @btn-default-bg;
@btn-default-border);
}

PS: I would also set the text-shadow to none or use the invert color of the @btn-default-color. If you change the theme to a dark skin, the buttons text shadow will not look very nice. What do you think about it?

border-color is not nessessary. The color will be defined in the
/less/buttons.less#60.
```
.btn-default {
  .button-variant(@btn-default-color; @btn-default-bg;
@btn-default-border);
}
```
@mdo
Copy link
Member

mdo commented Dec 19, 2014

If memory serves, I purposely reset the border-color to be sufficiently dark for contrast. The theme is going to be radically different in v4, so I'm hesitant to change anything else about it in v3. Thanks though!

@mdo mdo closed this Dec 19, 2014
@Ninos Ninos deleted the theme-btn-default branch December 19, 2014 02:06
@Ninos Ninos restored the theme-btn-default branch December 19, 2014 02:41
@Ninos
Copy link
Author

Ninos commented Dec 19, 2014

I just checked it again and the variable @btn-default-border already has the hex color #ccc. So for me it's still unclear :)

@cvrebert cvrebert added the css label Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants