More screenreader friendly hidden content #14444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: dist/css/bootstrap.css.map dist/css/bootstrap.min.css
mdo
added a commit
that referenced
this pull request
Aug 28, 2014
More screenreader friendly hidden content
Closed
|
This broke our collapse and tabs plugins, so it has to be reverted. |
cvrebert
referenced
this pull request
Aug 28, 2014
Saranya-Raaj
pushed a commit
to Saranya-Raaj/bootstrap
that referenced
this pull request
Oct 9, 2014
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
|
"This broke our collapse and tabs plugins, so it has to be reverted." Same here. If one wants to animate the nav bar (eg fade in) and visibility has been set on this, it causes the element to be shown before the animation has even started. Seems like a change that has not been thought about. |
|
@jessertaylor A more complete picture was presented in #14673. It's a technique pulled from the H5BP, originally from http://juicystudio.com/article/screen-readers-display-none.php. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14348 by adding
visibility: hiddenandvisibility: visibleto the collapse and tab content to match.hidden./cc @Willem-Siebe