Do csscomb earlier in build phase #12961
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referencing my discussion with @XhmikosR on the subject: #12861 (comment) |
|
Updated the PR per your request. I hadn't included the grunt dist-css results before, as @cvrebert mentioned in another one of my PR's that leaving those files out would help with a cleaner merge. |
|
I know, but I don't think anyone will merge anything before this is merged so there shouldn't be any conflicts :) That rule still applies. |
|
👍 |
XhmikosR
added a commit
that referenced
this pull request
Mar 7, 2014
Do csscomb earlier in build phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do csscomb after less:minify and cssmin.
As a result of this the reordered properties don't end up reordered in the bootstrap.min.css file at all and only end up in docs.min.css after a double grunt if docs.css is changed.
By doing the csscomb first we solve that.