Enforce LF

[XhmikosR]

Refs #12927

Another way would be to keep doing what we did and specify the filetypes ourselves, but this seems cleaner maybe :/

[XhmikosR]

/CC @cvrebert @juthilo

[juthilo]

Technically, text belongs in the same column as binary, but otherwise, this looks great. You be the judge on whether it reliably works though. :)

[XhmikosR]

I tested it and works as expected with autocrlf on Windows. :)

[XhmikosR]

This looks weird if I indent it like you suggest @juthilo :P

# Enforce Unix newlines for all the files in the repository
*       text    eol=lf
*.png   binary
*.jpg   binary

But I don't mind, whatever most people like...

[juthilo]

👍

[juthilo]

No no, leave it as is, it's fine. :)

[XhmikosR]

OK, I'll wait for @cvrebert's feedback too and then merge it.

[zlatanvasovic]

What about my credits for "Normalize line engings" commit?

[XhmikosR]

There's no credit to give to; I did it myself.

For reference https://help.github.com/articles/dealing-with-line-endings#re-normalizing-a-repository

[zlatanvasovic]

It doesn't differ from https://github.com/ZDroid/bootstrap/commit/0b7bbba2c9d442a8eaad60db27ab8b1cf7992b2e (except for the .gitattributes change). Whatever.

[XhmikosR]

Obviously it can't differ; it's the same thing. You didn't invent something new.

[cvrebert]

We should also set the applicable font file types as binary.

[XhmikosR]

Well, true, but they aren't touched by git so it seems pointless at this point. The types I added are modified by git if we don't specify them explicitly.

[XhmikosR]

@cvrebert: what do you think of this way? Should I just add svg instead of this?

[mdo]

Seems fine—tests are failing though.

[cvrebert]

That's just iOS 7 Safari being flaky.

[cvrebert]

@XhmikosR Either way seems fine.

[XhmikosR]

So which of the two ways do you prefer? I think I like more the other way, by adding svg only...

[cvrebert]

@XhmikosR Let's do the svg way then. I was slightly irrationally fearful about relying on autodetection anyway.