Fix UAs required message position on grouped radio buttons #12794
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of not rendering the element at all with display:none, use opacity:0 and z-index:-1 so the radio element has a defined position on the document and user agents can show the required message in the right place.
mdo
added a commit
that referenced
this pull request
Mar 7, 2014
Fix UAs required message position on grouped radio buttons
|
Verified the bug and fix on Firefox and Chrome OS X. |
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
…tton-groups Fix UAs required message position on grouped radio buttons
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the positioning of the required error message shown by user agents when using the
requiredattribute on radio inputs inside abtn-groupbutton group.JSFiddle example showcasing the problem. On Firefox the required message is rendered in bizarre places:
And on Chrome the message is not shown. An error is logged to the console instead: "An invalid form control with name='options' is not focusable."
JSFiddle example with fix. On firefox:
And on Chrome:
The fix/hack is basically, instead of not rendering the element at all with
display:none, usingopacity:0,position:absoluteandz-index:-1so the radio input element has a defined position on the document and user agents can show the required message in the right place but at the same time it is invisible and doesn't affect the position of other elements.Disclaimer: i only tested this in Firefox and Chrome on Ubuntu, and i don't know if those CSS properties are the best to "make an element have a position but be invisible" 😅
Cheers!