-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different coding style for Gruntfile #12657
Conversation
@@ -0,0 +1,6 @@ | |||
{ | |||
"eqnull" : true, | |||
"boss" : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe sort these alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I missed eqnull
@XhmikosR fixed. |
What's the reasoning again behind adding the semicolons for these files? Ideally we shouldn't need new .jshintrc files but I can't make grunt-contrib-jshint override specific properties via the Gruntfile either. |
I can make it override js/.jshintrc properties, but Gruntfile has different 2014-02-09 10:33 GMT+01:00 XhmikosR notifications@github.com:
Zlatan Vasović - ZDroid |
Merged (w/ some extra changes) as ba4206b. |
Yes, I saw. I just didn't want to change your code as you may not agree. :D 2014-02-10 20:20 GMT+01:00 Chris Rebert notifications@github.com:
Zlatan Vasović - ZDroid |
This adds new
.jshintrc
for Gruntfile and Grunt tasks and improves coding style checkers and references.Important: don't close this pull request until Grunt coding style is completely resolved. If pull request is closed I can't bring new changes. 😉