Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different coding style for Gruntfile #12657

Closed
wants to merge 1 commit into from
Closed

Use different coding style for Gruntfile #12657

wants to merge 1 commit into from

Conversation

zlatanvasovic
Copy link
Contributor

This adds new .jshintrc for Gruntfile and Grunt tasks and improves coding style checkers and references.

Important: don't close this pull request until Grunt coding style is completely resolved. If pull request is closed I can't bring new changes. 😉

@@ -0,0 +1,6 @@
{
"eqnull" : true,
"boss" : true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe sort these alphabetically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I missed eqnull

@zlatanvasovic
Copy link
Contributor Author

@XhmikosR fixed.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2014

What's the reasoning again behind adding the semicolons for these files?

Ideally we shouldn't need new .jshintrc files but I can't make grunt-contrib-jshint override specific properties via the Gruntfile either.

@zlatanvasovic
Copy link
Contributor Author

I can make it override js/.jshintrc properties, but Gruntfile has different
coding style. Chris may help you for details, as he's coding Grunt stuff
for Bootstrap.

2014-02-09 10:33 GMT+01:00 XhmikosR notifications@github.com:

What's the reasoning again behind adding the semicolons for these files?

Ideally we shouldn't need new .jshintrc files but I can't make
grunt-contrib-jshint override specific properties via the Gruntfile either.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12657#issuecomment-34569522
.

Zlatan Vasović - ZDroid

@cvrebert cvrebert closed this in ba4206b Feb 10, 2014
@cvrebert
Copy link
Collaborator

Merged (w/ some extra changes) as ba4206b.

@zlatanvasovic
Copy link
Contributor Author

Yes, I saw. I just didn't want to change your code as you may not agree. :D

2014-02-10 20:20 GMT+01:00 Chris Rebert notifications@github.com:

Merged (w/ some extra changes) as ba4206bhttps://github.com/twbs/bootstrap/commit/ba4206b6443ab3f5744f3a7f88bcdfcefa7c5756
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12657#issuecomment-34669420
.

Zlatan Vasović - ZDroid

@mdo mdo added this to the v3.1.1 milestone Feb 11, 2014
@zlatanvasovic zlatanvasovic deleted the grunt-coding-style branch February 14, 2014 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants