Reorganize docs assets #12505
Reorganize docs assets #12505
Conversation
| @@ -53,7 +53,7 @@ module.exports = function (grunt) { | |||
| src: 'js/tests/unit/*.js' | |||
| }, | |||
| assets: { | |||
| src: ['docs/assets/js/application.js', 'docs/assets/js/customizer.js'] | |||
| src: 'docs/assets/js/{application,customizer,ie8-responsive-file-warning}.js' | |||
There was a problem hiding this comment.
I'm onboard with trying to lint everything, but using brace expansion seems kinda messy.
Maybe we could move the minified assets into a subdirectory so that simple *.js globbing would work here?
There was a problem hiding this comment.
That was my original thought. But there is another solution: move *.js to the docs/assets/js/src and ignore docs/assets/js/ when build Jekyll site (like for docs/assets/js/vendor), but keep the *.min.js ones.
There was a problem hiding this comment.
@zdroid: I'm not sure you can ignore that folder due to a Jekyll bug.
There was a problem hiding this comment.
Are you sure? I tested directory ignore locally and it worked, I didn't catch any bug.
There was a problem hiding this comment.
What exactly did you add in the exclude array in _config.yml?
There was a problem hiding this comment.
You should move source js files to src/ then exclude src, like vendor.
There was a problem hiding this comment.
It shouldn't be too hard to separate the minified JS files. But we really need to stop generating raw-files.min since it's being minified again.
There was a problem hiding this comment.
There's no raw-files.js. raw-files.min.js isn't truly minified, its just not human-readable.
There was a problem hiding this comment.
That's what I meant. I know it's not truly minified but it is not used since it's just concatenated and minified to customize.min.js.
|
@cvrebert Any news? |
|
This is blocked until the minified vs. non-minified directory structure is sorted out. |
|
Maybe to move |
|
About pygment_manni.css, I was thinking to move it to vendor. Now for the rest, I will have a closer look tomorrow, but I guess this does the job. |
|
Good then. |
|
Perhaps we should move the outputs into |
|
I think those make sense, too @cvrebert. But I'm not sure which one of the two ways I prefer myself to be honest :P |
|
Yes, src/ should be used as we're using dist/. 2014-02-18 7:01 GMT+01:00 XhmikosR notifications@github.com:
Zlatan Vasović - ZDroid |
|
Done. |
|
LGTM. We can't use So I think this is good to merge. @cvrebert: waiting for your final word on this. :) |
|
This will need a rebase I think before we can merge. |
|
@XhmikosR LGTM. |
|
Awww the hell. I have to rebase this. |
|
@cvrebert What will we do with |
|
@zdroid That's not much of a priority right now. I wouldn't worry about it. |
|
Okay. 2014-03-07 17:24 GMT+01:00 Chris Rebert notifications@github.com:
Zlatan Vasović - ZDroid |
|
Everything should be fine now. |
No description provided.