Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from uber/npm-shrinkwrap to regular npm shrinkwrap #18559

Closed
cvrebert opened this issue Dec 12, 2015 · 10 comments
Closed

Migrate from uber/npm-shrinkwrap to regular npm shrinkwrap #18559

cvrebert opened this issue Dec 12, 2015 · 10 comments
Labels
build v4
Milestone
v4.0.0-alpha.3

Comments

@cvrebert
Copy link
Collaborator

Fixes #19596.
The shrinkwrap output consistency issue has allegedly been fixed in npm@3: npm/npm#10731
@XhmikosR
Copy link
Member

Is this still valid @cvrebert?

@cvrebert
Copy link
Collaborator Author

Affirmative.

@XhmikosR
Copy link
Member

Do you want me to make a test branch against v4-dev for this? I'm all for reducing the dependencies if we can.

@cvrebert
Copy link
Collaborator Author

Sure.

@XhmikosR
Copy link
Member

You still don't want npm-shrinkwrap.json in root? It would make things simpler.

This is with the file moved in root: v4-dev...v4-dev-rm-shrinkwrap-dep

@cvrebert
Copy link
Collaborator Author

This is now more important since https://news.ycombinator.com/item?id=11340510 has made npm-shrinkwrap impossible to install, at least temporarily.
I'll try to take a look at this.

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Mar 23, 2016
@XhmikosR
Copy link
Member

If you don't need the dest change, the patch is ready :P

@cvrebert cvrebert changed the title Try using regular npm shrinkwrap instead of uber/npm-shrinkwrap Migrate from uber/npm-shrinkwrap to regular npm shrinkwrap Mar 23, 2016
@cvrebert cvrebert mentioned this issue Mar 23, 2016
Closed
@cvrebert
Copy link
Collaborator Author

I'll make the dest change and try to avoid grunt-exec.

@XhmikosR
Copy link
Member

👍 Feel free to push to this branch.

Should we also backport this to master too?

@cvrebert
Copy link
Collaborator Author

If we're currently using uber/npm-shrinkwrap there too, then yes. I'll backport the patch once it's finalized.

cvrebert added a commit that referenced this issue Mar 24, 2016
@cvrebert
Use vanilla npm shrinkwrap instead of uber/npm-shrinkwrap; fixes #18559
768dac2
@cvrebert cvrebert mentioned this issue Mar 24, 2016
Merged
cvrebert added a commit that referenced this issue Mar 24, 2016
@cvrebert
Use vanilla npm shrinkwrap instead of uber/npm-shrinkwrap; fixes #18559
0af30aa 
Ports #19604 to v3.

Special thanks to @kikinteractive, @azer, and @npm.
@cvrebert cvrebert mentioned this issue Mar 24, 2016
Merged
chiraggmodi pushed a commit to chiraggmodi/bootstrap that referenced this issue Apr 8, 2019
@cvrebert @chiragatlas
Use vanilla npm shrinkwrap instead of uber/npm-shrinkwrap; fixes twbs…
44e59bc 
…#18559

Ports twbs#19604 to v3.

Special thanks to @kikinteractive, @azer, and @npm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
2 participants
@XhmikosR @cvrebert