Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button position without label #14642

Closed
sama55 opened this issue Sep 18, 2014 · 6 comments
Closed

Radio button position without label #14642

sama55 opened this issue Sep 18, 2014 · 6 comments

Comments

@sama55
Copy link

sama55 commented Sep 18, 2014

It seems that position of radio button "without label" is strange.
I saw thread and CSS of related issue below.
#13997
e2029e1
But, when I removed label of radio in bootstrap CSS example page below, radio button position is strange on Google Chrome.
http://getbootstrap.com/css/#forms-controls

Change for issue 13997 is correct? Or is HTML markup of example page wrong?

Thanks.

@cvrebert
Copy link
Collaborator

We haven't made a release since that fix was merged. You'd need to test against master instead of v3.2.0.

@cvrebert
Copy link
Collaborator

Yeah, still looks broken to me.

@mdo
Copy link
Member

mdo commented Sep 18, 2014

It was likely fixed when we were using float and margin only to position the input, but now that we're using position: absolute;, we need to add top: 0; I think, too.

@mdo mdo added this to the v3.2.1 milestone Sep 18, 2014
@cvrebert
Copy link
Collaborator

We should probably add a visual test for this.

@mdo
Copy link
Member

mdo commented Sep 19, 2014

Gah, I actually don't think there's much we can do here with the way this stuff is currently implemented. We really just ought to roll back the position: absolute; shit. It's way too much of a pain right now for little trade off (clicking in the exact negative space between input and label text).

@mdo
Copy link
Member

mdo commented Sep 19, 2014

Nevermind, got it working—was using the inline radios/checkboxes, for which this won't work because of their lack of surrounding div.

@mdo mdo closed this as completed in 642fbf7 Sep 19, 2014
callistino pushed a commit to callistino/bootstrap that referenced this issue Sep 22, 2014
* 'master' of github.com:callistino/bootstrap: (102 commits)
  the justified nav bug is still present in Safari v7.1
  grunt
  Fixes twbs#14592: Add new variable for progress border radius
  grunt
  Fixes twbs#14642: Add docs mention for blank checkboxes and radios
  grunt
  Make it easier to see failing tests in Sauce screencasts
  tweak `grunt docs` description
  fix twbs#14609
  Follow-up to twbs#14581: Use div instead of HTML5 section for IE8
  Fix tooltip misplacement with "auto top"
  Fixes twbs#14628, twbs#14629: Add note to docs about grunt docs command
  grunt
  grunt
  Must explicitly destroy tooltip in SVG unit test since its container
is body.
  modal docs: ensure all <button>s have an explicit `type` attribute
  Update github links in footer.
  README.md: Add npm install info.
  Remove unused Tooltip#validate method
  grunt
  ...

Conflicts:
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	docs/_includes/components/badges.html
	docs/_includes/components/input-groups.html
	docs/_includes/components/pagination.html
	docs/_includes/js/collapse.html
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.js
	docs/dist/js/bootstrap.min.js
	less/dropdowns.less
	less/forms.less
	less/jumbotron.less
	less/panels.less
	less/print.less
Saranya-Raaj pushed a commit to Saranya-Raaj/bootstrap that referenced this issue Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants