Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .small in type.less use the @font-size-small variable? #13713

Closed
dminkovsky opened this issue May 31, 2014 · 2 comments · Fixed by #13882
Closed

Make .small in type.less use the @font-size-small variable? #13713

dminkovsky opened this issue May 31, 2014 · 2 comments · Fixed by #13882
Labels

Comments

@dminkovsky
Copy link

Right now, the misc .small mixin in type.less is hardwired to 85%. That same 85% of base appears in variables.less as @font-size-small. Would it makes sense to have .small in type.less reference @font-size-small instead of having its own value?

@dminkovsky dminkovsky changed the title Make .small in type.less use the @font-size-small variable? Make .small in type.less use the @font-size-small variable? May 31, 2014
@cvrebert cvrebert added the css label May 31, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone May 31, 2014
@mdo
Copy link
Member

mdo commented Jun 11, 2014

For now I'll punt on this as the default <small>/.small should use a percentage and not the computed value. We'll have to revisit this in v4 to make things a bit easier.

@mdo mdo closed this as completed Jun 11, 2014
@mdo mdo removed this from the v3.2.1 milestone Jun 11, 2014
@thomaswelton
Copy link
Contributor

@mdo / @cvrebert can we change this so that this value

font-size: 85%;

Is computed by using the variables font-size-small and font-size-base while still using a percentage value?

At least that way we'd get results more like users may expect.
I just ran into this problem myself and was surprised the variable was not being used here and caused a bug with my font size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants