Skip to content

Commit

Permalink
Fixes #11425: Use margin instead of padding on .modal-dialog to enabl…
Browse files Browse the repository at this point in the history
…e click-thru to .modal-backdrop
  • Loading branch information
mdo committed Nov 30, 2013
1 parent 36b82c3 commit bf9f392
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions dist/css/bootstrap.css
Original file line number Diff line number Diff line change
Expand Up @@ -5909,7 +5909,7 @@ button.close {
position: relative;
z-index: 1050;
width: auto;
padding: 10px;
margin: 10px;
margin-right: auto;
margin-left: auto;
}
Expand Down Expand Up @@ -6009,8 +6009,8 @@ button.close {
@media screen and (min-width: 768px) {
.modal-dialog {
width: 600px;
padding-top: 30px;
padding-bottom: 30px;
margin-top: 30px;
margin-bottom: 30px;
}
.modal-content {
-webkit-box-shadow: 0 5px 15px rgba(0, 0, 0, 0.5);
Expand Down
2 changes: 1 addition & 1 deletion dist/css/bootstrap.min.css

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions less/modals.less
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
margin-left: auto;
margin-right: auto;
width: auto;
padding: 10px;
margin: 10px;
z-index: (@zindex-modal-background + 10);
}

Expand Down Expand Up @@ -122,8 +122,8 @@

.modal-dialog {
width: 600px;
padding-top: 30px;
padding-bottom: 30px;
margin-top: 30px;
margin-bottom: 30px;
}
.modal-content {
.box-shadow(0 5px 15px rgba(0,0,0,.5));
Expand Down

2 comments on commit bf9f392

@wizsilex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is no good, as modals are positioned 10px from left with margin:10px it overrides margin-left: auto and margin-right: auto.
please move it above the margin-left and margin-right: auto, so they override the margin: 10px

@mdo
Copy link
Member Author

@mdo mdo commented on bf9f392 Nov 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved per your PR. Thanks for pointing out <3.

Please sign in to comment.