-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #11425: Use margin instead of padding on .modal-dialog to enabl…
…e click-thru to .modal-backdrop
- Loading branch information
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf9f392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix is no good, as modals are positioned 10px from left with margin:10px it overrides margin-left: auto and margin-right: auto.
please move it above the margin-left and margin-right: auto, so they override the margin: 10px
bf9f392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved per your PR. Thanks for pointing out <3.