fix(health): bootstrap Git for Windows runtime in PowerShell - #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, a normal PowerShell or Codex process can find Git while Git for Windows' Unix runtime directories are absent from
PATH. Health's update and collection commands then resolve the Windows WSL launcher or fail on tools such assed, forcing users to prepend Git runtime paths manually.Root cause
Health invoked Bash without first resolving the actual Git for Windows installation and constructing an isolated child environment.
Fix
git.exeorbash.exe;usr/bin,mingw64/bin,bin, andcmdonly for the Health Bash child;Verification
c1a0d6e:sedwas unavailable,bashresolved to the Windows WSL launcher, and both update and collect exited 1 with WSL diagnostic noise.sed/not foundnoise.verify_skills.py, generated-mirror verification, routing verification, shell syntax, Python compilation, packaging, and post-package validation passed.PATHand target Git status were unchanged before and after the runtime smoke.Known baseline limitation
tests/python/test_build_metadata.py::test_collect_skill_shared_assets_copies_durable_context_when_linkedexpects LF bytes but receives CRLF on Windows. It fails identically on pristine upstream and this branch; this PR does not change that test.Out of scope