Avoid recursive container stub cleanup#1113
Merged
Merged
Conversation
Owner
|
@M-Hassan-Raza Merged, thanks. Replacing the The regression test that injects raced content and asserts it's preserved is a nice touch, it fails on the old path and passes on the new one. Verified locally with the format check and the full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Change orphaned container-stub cleanup to remove only the verified metadata plist, then rmdir the container instead of recursively deleting the directory.
Why:
The old path verified a metadata-only container, then ran rm -rf on the directory. If anything appeared after verification, that recursive delete could remove content that was no longer part of the verified stub.
Validation:
./scripts/check.sh --format
./scripts/check.sh
env -u NO_COLOR MOLE_TEST_NO_AUTH=1 bats tests/clean_apps.bats
MOLE_TEST_NO_AUTH=1 bats --filter "clean_orphaned_container_stubs preserves content that appears during removal" tests/clean_apps.bats
env -u NO_COLOR MOLE_TEST_NO_AUTH=1 ./scripts/test.sh