Merged
Conversation
slifty
force-pushed
the
32-add-http-ingestion-appliance
branch
2 times, most recently
from
0b1f476 to
9669521
Compare
chriszs
approved these changes
Aug 26, 2020
Contributor
chriszs
left a comment
chriszs
left a comment
There was a problem hiding this comment.
Having written at least some of this, I approve of it.
packages/video-http-ingestion/src/VideoHttpIngestionAppliance.js
Outdated
Show resolved
Hide resolved
slifty
force-pushed
the
32-add-http-ingestion-appliance
branch
from
9669521 to
9606b55
Compare
slifty
commented
Aug 26, 2020
packages/video-http-ingestion/src/VideoHttpIngestionAppliance.js
Outdated
Show resolved
Hide resolved
The @tvkitchen/appliance-video-http-ingestion package will take a given video URL and convert it to STREAM.CONTAINER payloads. Issue #32 Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
slifty
force-pushed
the
32-add-http-ingestion-appliance
branch
from
9606b55 to
6c2c95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an appliance that can convert a video URL into STREAM.CONTAINER payloads.
Due Diligence Checklist
Steps to Test
yarn testDeploy Notes
yarn installRelated Issues
This is the final ingestion engine to be converted, so it resolves #32
Relies on #36