fix(EAV-372): settings lost on studio update #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrashekar-nallamilli
force-pushed
the
release53
branch
from
ccc7914 to
37ca22e
Compare
ianshade
force-pushed
the
contribute/EAV-588
branch
from
725da4a to
5c235bc
Compare
Collaborator
|
Do we need this one? We will get the changes once merged upstream |
properties not present in apiStudio needed to be taken from the existing studio refactor(EAV-588): extract `studioFrom` logic ... and add test coverage refactor(EAV-588): small changes for clarity fix(EAV-598): make `updateOverrides` respect deep property overrides, not generate invalid overrides, and correctly preserve existing overrides fix(EAV-588): add null checks
ianshade
force-pushed
the
contribute/EAV-588
branch
from
5c235bc to
d6df5c1
Compare
chandrashekar-nallamilli
force-pushed
the
release53
branch
3 times, most recently
from
4df992a to
25fb026
Compare
Collaborator
|
can be closed - merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix from release52 to release53
This PR brings the EAV-372 studio update fix to release53.
Upstream status: Pending in Sofie-Automation#1455 (has conflicts)
Changes:
This ensures feature parity with our release52 deployment.