Skip to content

fix(EAV-518): offset lookaheads following other lookaheads by 1 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandrashekar-nallamilli merged 1 commit into from
Mar 6, 2025
Merged

fix(EAV-518): offset lookaheads following other lookaheads by 1 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/job-worker/src/playout/lookahead/__tests__/__snapshots__/lookahead.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ exports[`Lookahead got some objects 1`] = `
"disabled": false,
"enable": {
"end": "#piece1obj1.start",
"start": "#piece0obj0.start + 0",
"start": "#piece0obj0.start + 1",
},
"id": "lookahead_timed1_piece1obj1",
"isLookahead": true,
Expand Down Expand Up @@ -101,7 +101,7 @@ exports[`Lookahead got some objects 1`] = `
"disabled": false,
"enable": {
"end": "#piece0obj6.start",
"start": "#piece1obj5.start + 0",
"start": "#piece1obj5.start + 1",
},
"id": "lookahead_timed1_piece0obj6",
"isLookahead": true,
Expand All @@ -115,7 +115,7 @@ exports[`Lookahead got some objects 1`] = `
},
"disabled": false,
"enable": {
"start": "#piece0obj6.start + 0",
"start": "#piece0obj6.start + 1",
},
"id": "lookahead_future0_piece1obj7",
"isLookahead": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/job-worker/src/playout/lookahead/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ const calculateStartAfterPreviousObj = (
const prevHasDelayFlag = (prevObj.classes || []).indexOf('_lookahead_start_delay') !== -1

// Start with previous piece
const startOffset = prevHasDelayFlag ? 2000 : 0
const startOffset = prevHasDelayFlag ? 2000 : 1 // has to be 1, because 0 causes a clash with previous object in superfly-timeline
return {
start: `${getStartOfObjectRef(prevObj)} + ${startOffset}`,
}
Expand Down
Loading