Skip to content

feat(config): upgrade Biome.js to v2.3.10 and optimize framework configs #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tutods merged 6 commits into from
Dec 20, 2025
Merged

feat(config): upgrade Biome.js to v2.3.10 and optimize framework configs #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
54d6a39
Initial plan
Copilot Dec 20, 2025
1ad11ab
feat(config): upgrade Biome.js to v2.3.10 with new rules
Copilot Dec 20, 2025
6f886a8
chore: remove BIOME_UPGRADE_REPORT.md file per feedback
Copilot Dec 20, 2025
0180840
refactor(config): remove duplicate rules from framework-specific configs
Copilot Dec 20, 2025
c947abc
fix(config): disable frontend-specific rules in backend/solidjs configs
Copilot Dec 20, 2025
c848347
Merge branch 'main' into copilot/upgrade-biomejs-configuration
tutods Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions configs/biome-config/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
"vcs": {
"clientKind": "git",
"enabled": true,
Expand Down Expand Up @@ -183,7 +183,16 @@
"attributes": ["css", "class", "classList", "classNames", "className"],
"functions": ["clsx", "cva", "tv", "tw", "twMerge", "cn"]
}
}
},
"noScriptUrl": "error",
"useArraySortCompare": "error",
"useAwaitThenable": "error",
"useRegexpExec": "warn",
"noEqualsToNull": "error",
"noLeakedRender": "error",
"noDuplicatedSpreadProps": "error",
"noAmbiguousAnchorText": "warn",
"noMultiStr": "error"
Comment on lines +187 to +195
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of these rules may have graduated from the nursery category in Biome v2.3.10 and should be placed in their appropriate stable categories instead:

  • noScriptUrl should likely be in the "security" category
  • useArraySortCompare, useAwaitThenable, useRegexpExec, and noEqualsToNull should likely be in the "suspicious" category
  • noMultiStr should likely be in the "style" category
  • noAmbiguousAnchorText should likely be in the "a11y" category

Placing rules in the wrong category can cause configuration issues when these rules graduate from nursery. Please verify the correct category for each rule in the Biome v2.3.10 documentation and move them to their appropriate stable categories if they've graduated.

Copilot uses AI. Check for mistakes.
},
"performance": {
"recommended": true,
Expand Down
26 changes: 13 additions & 13 deletions configs/biome-config/nestjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
"javascript": {
"parser": {
"unsafeParameterDecoratorsEnabled": true
Expand All @@ -9,23 +9,23 @@
"rules": {
"complexity": {
"noStaticOnlyClass": "off",
"noUselessConstructor": "off"
"noUselessConstructor": "off",
"noUselessFragments": "off"
},
"style": {
"useImportType": "off",
"noParameterAssign": "error",
"useAsConstAssertion": "error",
"useDefaultParameterLast": "error",
"useEnumInitializers": "error",
"useSelfClosingElements": "error",
"useSingleVarDeclarator": "error",
"noUnusedTemplateLiteral": "error",
"useNumberNamespace": "error",
"noInferrableTypes": "error",
"noUselessElse": "error"
"useImportType": "off"
},
"correctness": {
"useHookAtTopLevel": "off"
},
"a11y": {
"recommended": false
},
"nursery": {
"noLeakedRender": "off",
"noDuplicatedSpreadProps": "off",
"noAmbiguousAnchorText": "off",
"useSortedClasses": "off"
}
}
}
Expand Down
13 changes: 1 addition & 12 deletions configs/biome-config/nextjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
"files": {
"includes": ["**", "!**/.next", "!**/.vercel", "!**/.turbo", "!**/next-env.d.ts"]
},
Expand All @@ -17,18 +17,7 @@
"useAltText": "error",
"useValidAnchor": "error"
},
"nursery": {},
"style": {
"noParameterAssign": "error",
"useAsConstAssertion": "error",
"useDefaultParameterLast": "error",
"useEnumInitializers": "error",
"useSelfClosingElements": "error",
"useSingleVarDeclarator": "error",
"noUnusedTemplateLiteral": "error",
"useNumberNamespace": "error",
"noInferrableTypes": "error",
"noUselessElse": "error",
"noHeadElement": "error"
},
"performance": {
Expand Down
15 changes: 3 additions & 12 deletions configs/biome-config/solidjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.3.10/schema.json",
"files": {
"includes": ["**", "!**/.vinxi", "!**/.output"]
},
Expand All @@ -8,17 +8,8 @@
"suspicious": {
"noReactSpecificProps": "error"
},
"style": {
"noParameterAssign": "error",
"useAsConstAssertion": "error",
"useDefaultParameterLast": "error",
"useEnumInitializers": "error",
"useSelfClosingElements": "error",
"useSingleVarDeclarator": "error",
"noUnusedTemplateLiteral": "error",
"useNumberNamespace": "error",
"noInferrableTypes": "error",
"noUselessElse": "error"
"correctness": {
"useHookAtTopLevel": "off"
}
}
},
Expand Down