Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flow typing for Mithril #3359

Closed
1 task done
charlag opened this issue Aug 6, 2021 · 0 comments · Fixed by #3360
Closed
1 task done

Fix flow typing for Mithril #3359

charlag opened this issue Aug 6, 2021 · 0 comments · Fixed by #3360
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.86.3

Comments

@charlag
Copy link
Contributor

charlag commented Aug 6, 2021 •
edited by johnbotris
Loading

Currently type of Attrs is not really checked. See: facebook/flow#8718

--

Test notes

  • Select/unselect registration domain for whitelabel (needs WhitelabelParent feature)
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Aug 6, 2021
charlag added a commit that referenced this issue Aug 6, 2021
@charlag
Fix Flow typing for Mithril, fix #3359
6581d18
@charlag charlag mentioned this issue Aug 6, 2021
Merged
charlag added a commit that referenced this issue Aug 6, 2021
@charlag
Fix Flow typing for Mithril, fix #3359
7037b70
@charlag charlag added the state:done meets our definition of done label Aug 6, 2021
@jowlo jowlo added this to the 3.86.0 milestone Aug 6, 2021
johnbotris pushed a commit that referenced this issue Aug 10, 2021
@charlag @johnbotris
Fix Flow typing for Mithril, fix #3359
eb9cd87
@johnbotris johnbotris assigned ghost Aug 13, 2021
@johnbotris johnbotris added the state:tested We tested it and are about to release it label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.86.3
Development

Successfully merging a pull request may close this issue.

Fix Flow typing for Mithril tutao/tutanota
3 participants
@charlag @jowlo @johnbotris