Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3store: Allow customizing upload ID, object ID and bucket #1167

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Acconut
Copy link
Member

@Acconut Acconut commented Aug 2, 2024

Previously, the upload ID included the multipart ID, which made fully customizing the upload ID (and thus upload URL) impossible. With this PR, we hope to allow full customization of the upload ID and even the destination object key.

Overall changes:

  • Removes the multipart ID from the upload ID and instead loads it from the info file
  • Allow customization of upload ID
  • Allow customization of destination object key via Storage.Key
  • Allow customization of destination bucket via Storage.Bucket

TODO:

  • Manual testing
  • Allow customization of S3 metadata
  • Allow customization of S3 storage class
  • Allow customization of Content-Type, Content-Encoding, Content-Language and Content-Disposition

@Acconut Acconut self-assigned this Aug 2, 2024
@Acconut Acconut changed the title s3store: Allow customizing upload ID and object ID s3store: Allow customizing upload ID, object ID and bucket Sep 18, 2024
@Acconut Acconut added this to the v3 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Backwards compatibility breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant