Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI cache problems #686

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix CI cache problems #686

merged 2 commits into from
Oct 10, 2023

Conversation

athoscouto
Copy link
Collaborator

No description provided.

Also remove install dependencies step since it can generate
problems with setup-go.
@athoscouto athoscouto requested a review from gris October 10, 2023 00:51
@athoscouto athoscouto temporarily deployed to internal October 10, 2023 00:52 — with GitHub Actions Inactive
@@ -1,15 +1,17 @@
# Turso CLI

[![goreleaser](https://github.com/tursodatabase/turso-cli/actions/workflows/goreleaser.yml/badge.svg)](https://github.com/tursodatabase/turso-cli/actions/workflows/goreleaser.yml)
[![Go](https://github.com/tursodatabase/turso-cli/actions/workflows/go.yml/badge.svg)](https://github.com/tursodatabase/turso-cli/actions/workflows/go.yml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing goreleaser? I think both are useful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally we just used go.yml.

But it always failed because of conflicts when we restored the cache.
Screenshot 2023-10-10 at 8 26 05 AM
This resulted in the errors you see above and also on a red status badge.
That is why @gris changed it to goreleaser.yml a few days ago.

I think a CI badge makes more sense. Meaning that the "last CI run was successful for this project".
I don't see much value in a badge saying "the last release was successful". But I also don't oppose having it.
Let me know if you still want to keep gorereleaser badge and I'll add it back. @gris let me know what you think as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense! Thanks for spotting that

Copy link
Collaborator

@haaawk haaawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is cache really useless in self hosted runners? Is it because we don't clean up the runners between CI runs?

@athoscouto
Copy link
Collaborator Author

@haaawk I think so. I was reading issues on setup-go repo to understand what was the problem here and came across this.
It is also a bit harmful since we transfer that huge amount of data (300MB+) on every run and it resulted in errors that made our badge look broken.

@athoscouto athoscouto merged commit ad4bcb9 into main Oct 10, 2023
2 checks passed
@athoscouto athoscouto deleted the athos/ci branch October 10, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants