Ensure DB ID is set if namespaces are enabled #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinassh
commented
Dec 7, 2023
Comment on lines
+158
to
+165
| Ok(res) => { | ||
| let res = res.trim().to_string(); | ||
| if res.is_empty() { | ||
| bail!("{} environment variable is empty", key) | ||
| } else { | ||
| Ok(res) | ||
| } | ||
| } |
There was a problem hiding this comment.
If we don't trim, then it lets us slip in values containing just spaces or export LIBSQL_BOTTOMLESS_DATABASE_ID=''. I don't think we ever want env variables to have spaces, trimming seems like a must.
psarna
approved these changes
Dec 7, 2023
psarna
reviewed
Dec 7, 2023
| @@ -155,12 +155,19 @@ impl Options { | |||
| pub fn from_env() -> Result<Self> { | |||
| fn env_var(key: &str) -> Result<String> { | |||
There was a problem hiding this comment.
I preemptively acked, but before we merge -- should all env_var callsites disallow empty vars?
There was a problem hiding this comment.
@avinassh can you double-check before I queue this?
There was a problem hiding this comment.
@psarna hey, let me double check all of the vars if we are using empty vars anywhere
There was a problem hiding this comment.
@psarna I have double checked all, we don't expect empty variables to be set anywhere in bottomless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #765