libsql: Improve WAL frame push logic #1817
Merged
+19
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server returns its maximum frame number so let's use that as a hint to avoid pushing frames it already knows about. IOW, let's start by sending the first frame in the WAL, but immediately skip to a the server's max frame number. Later we should also cache the server max frame number on client side to make the first push start from the right frame.
penberg
force-pushed
the
optimize-wal-push
branch
from
ddd1c89
to
37bc47d
Compare
LucioFranco
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server returns its maximum frame number so let's use that as a hint to avoid pushing frames it already knows about. IOW, let's start by sending the first frame in the WAL, but immediately skip to a the server's max frame number. Later we should also cache the server max frame number on client side to make the first push start from the right frame.