Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsql-wal replication fixed #1769

Merged
merged 1 commit into from
Oct 3, 2024
Merged

libsql-wal replication fixed #1769

merged 1 commit into from
Oct 3, 2024

Conversation

MarinPostma
Copy link
Contributor

@MarinPostma MarinPostma commented Oct 3, 2024 •
edited
Loading

This PR fixes issues related to the integration of libsql-wal replication:

  • auth issue: we changed auth to disambiguate between internal and external services, that didn't reflect on libsql-wal replication
  • replication wasn't setup to retrieve the replica current frame_no and was replicating for scratch on restart
  • when replica restarts, start replicating from the last durable frame_no to account for primary potential data loss

@MarinPostma MarinPostma enabled auto-merge October 3, 2024 18:07
@MarinPostma MarinPostma disabled auto-merge October 3, 2024 18:08
@MarinPostma MarinPostma force-pushed the libsql-wal-replication-fixes branch from 2d80840 to db9d6e1 Compare October 3, 2024 18:23
@MarinPostma MarinPostma enabled auto-merge October 3, 2024 18:24
@MarinPostma MarinPostma added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 87001c0 Oct 3, 2024
18 checks passed
@MarinPostma MarinPostma deleted the libsql-wal-replication-fixes branch October 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarinPostma