Avoid dynamic require of the native package#200
Merged
penberg merged 1 commit intotursodatabase:v0.5from Aug 26, 2025
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes libsql with
next build --turbopack: vercel/next.js#82881 (comment)When combined with a non-isolating hoisting package manager (e.g. pnpm avoids this problem), these requires are written in a way that bundlers may be forced to pull in extra packages and files that are also under the
@libsql/namespace. Even if this doesn't cause issues with certain tooling, it's playing with fire.This could be written in a more clever way, but this writes it in the simplest-to-analyze possible way that should work with all bundlers. There's no real standard for what is or isn't statically analyzable by a bundler.
This is a PR for the
v0.5branch.v0.6.x does not appear to have this problem, as it's written in a similar way to this, where there are simple
require()expressions with static strings.