Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libsqlerror): add explanation field that details error #16

Merged

Conversation

douglasmdev
Copy link
Contributor

@douglasmdev douglasmdev commented Aug 3, 2023

  • same value as message. The different name is so that it doesn't conflict with a property on the BaseException called message
  • before this, to find more info on the error, the dev would have to call .args, which is not ideal

Issue: #15

- same value as message. The different name is so that it doesn't
  conflict with a property on the BaseException called message
- before this, to find more info on the error, the dev would have to
  call .args, which is not ideal
@barbieri barbieri requested a review from honzasp August 3, 2023 13:44
Copy link
Contributor

@barbieri barbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@penberg penberg merged commit 484c7d3 into tursodatabase:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants