Skip to content

Artemis: Refactor: Improve efficiency of SingleForLoop methods #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Artemis: Refactor: Improve efficiency of SingleForLoop methods #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/llm_benchmark/control/single.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ def sum_range(n: int) -> int:
Returns:
int: Sum of range of numbers from 0 to n
"""
arr = []
for i in range(n):
arr.append(i)
return sum(arr)
return (n * (n - 1)) // 2

@staticmethod
def max_list(v: List[int]) -> int:
Expand All @@ -27,11 +24,7 @@ def max_list(v: List[int]) -> int:
Returns:
int: Maximum value in the vector
"""
max_val = v[0]
for i in range(1, len(v)):
if v[i] > max_val:
max_val = v[i]
return max_val
return max(v) if v else 0

@staticmethod
def sum_modulus(n: int, m: int) -> int:
Expand All @@ -44,8 +37,7 @@ def sum_modulus(n: int, m: int) -> int:
Returns:
int: Sum of modulus of numbers from 0 to n
"""
arr = []
for i in range(n):
if i % m == 0:
arr.append(i)
return sum(arr)
sum_val = 0
for i in range(0, n, m):
sum_val += i
return sum_val