Skip to content

Artemis: Refactor query_album Function for Enhanced Security and Efficiency #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Artemis: Refactor query_album Function for Enhanced Security and Efficiency #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/llm_benchmark/sql/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ def query_album(name: str) -> bool:
conn = sqlite3.connect("data/chinook.db")
cur = conn.cursor()

cur.execute(f"SELECT * FROM Album WHERE Title = '{name}'")
return len(cur.fetchall()) > 0
cur.execute("SELECT EXISTS(SELECT 1 FROM Album WHERE Title = ?)", (name,))
exists = cur.fetchone()[0]
conn.close()
return exists

@staticmethod
def join_albums() -> list:
Expand Down Expand Up @@ -75,4 +77,4 @@ def top_invoices() -> list:
"""
)
)
return cur.fetchall()[:10]
return cur.fetchall()[:10]