Artemis: Refactor and Optimize Prime Number Utilities#60
Open
mike-turintech wants to merge 1 commit intomainfrom
Open
Artemis: Refactor and Optimize Prime Number Utilities#60mike-turintech wants to merge 1 commit intomainfrom
mike-turintech wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request refactors and optimizes the prime number utilities to improve performance, align with modern Java practices, and correct logical errors in the
SumPrimesmethod.Key Changes
Data Structure Update:
VectorwithListandArrayListfor enhanced performance and modern usage standards. This update affects both thePrimeFactorsmethod and the internal list used inSumPrimes.Logic Optimization in
SumPrimes:SumPrimesto iterate from 2 ton(inclusive), ensuring the sum includes all prime numbers up tonrather than the firstnprime numbers.List<Integer>to store identified prime numbers before summing, separating the concerns of identification and summation for improved readability and maintainability.Code Style and Readability Enhancements:
ListandArrayListto replace the deprecated use ofVector.PrimeFactorsfromVector<Integer>toList<Integer>to conform with modern Java conventions.Benefits
VectortoListandArrayListprovides a more efficient and modern approach to handling collections.SumPrimesnow accurately sums all prime numbers up ton, addressing previous inaccuracies.Conclusion
These changes collectively aim to modernize the codebase, correct logical errors, and enhance overall performance and readability.