refactor: optimize Single class with O(1) algorithms and validation#131
Open
vboursinos wants to merge 1 commit intomainfrom
Open
refactor: optimize Single class with O(1) algorithms and validation#131vboursinos wants to merge 1 commit intomainfrom
vboursinos wants to merge 1 commit intomainfrom
Conversation
``` refactor: improve code quality and implementation Applied general improvements to enhance code structure, readability, and maintainability based on review feedback. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces inefficient O(n) implementations in Single class with O(1) mathematical formulas and adds input validation.
Changes
Testing
Notes
Breaking change: maxArray now throws IllegalArgumentException for null arrays instead of NullPointerException. sumModulus and sumRange now validate inputs and throw exceptions for invalid values.