Skip to content

Optimize trivial wrapper function with inline keyword and add header guard #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize trivial wrapper function with inline keyword and add header guard #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/os/winheader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,13 @@

namespace OsWinHeader {

void ShowMessage(const char* message);
// Accept message as const char* to avoid string copy.
// Mark function as inline to give compiler opportunity to optimize out-of-header usage for this trivial wrapper.
// Add noexcept for better codegen and possible optimization.
inline void ShowMessage(const char* message) noexcept {
MessageBoxA(nullptr, message, "Info", MB_OK | MB_ICONINFORMATION);
}

}

#endif // ! __OS_WINHEADER_H__
#endif // ! __OS_WINHEADER_H__