Skip to content

Artemis: Update code to start range at 2 for correct sum of primes calculation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Artemis: Update code to start range at 2 for correct sum of primes calculation #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/llm_benchmark/algorithms/primes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ def is_prime(n: int) -> bool:
return True

@staticmethod
def sum_primes(n: int) -> int:
def sum_primes(n: int) -> int:
"""Sum of primes from 0 to n (exclusive)

Args:
n (int): Number to sum up to

Returns:
int: Sum of primes from 0 to n
"""
sum_ = 0
for i in range(n):
for i in range(2, n):
if Primes.is_prime(i):
sum_ += i
return sum_
Expand All @@ -52,4 +52,4 @@ def prime_factors(n: int) -> List[int]:
ret.append(i)
n = n // i
break
return ret
return ret