fix: align versioning and write official firmware version #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenrademakers
force-pushed
the
feature/fw_version
branch
from
bcfbafd to
fa31d93
Compare
/etc/os-release will now contain the official version of the turing-pi firmware under the key `VERSION`. The version will be determined by `git describe --tags` and can be overwritten during the build by setting the env var `BUILD_VERSION` part of #240
svenrademakers
force-pushed
the
feature/fw_version
branch
from
fa31d93 to
7c3e859
Compare
BinaryMan32
reviewed
Mar 1, 2025
| build_version=$(git describe --tags) | ||
| if [[ $? -ne 0 ]]; then | ||
| echo "Error: Failed to get version from git describe" | ||
| build_vrsion="v2-unknown" |
There was a problem hiding this comment.
typo here
Suggested change
| build_vrsion="v2-unknown" | |
| build_version="v2-unknown" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/os-release will now contain the official version of the turing-pi firmware under the key
VERSION.The version will be determined by
git describe --tagsand can be overwritten during the build by setting the env varBUILD_VERSIONpart of #240