GitHub tree #133

asfaltboy · 2022-01-29T16:43:57Z

Example query results

Results

Add example SQL query results here (please include the input queries as well)

github-actions · 2022-04-21T23:32:07Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

cbruno10 · 2022-04-22T19:50:25Z

Hey @asfaltboy , thanks for opening this PR and sorry we've missed it for so long! I'm going to re-open it and we'll review it early next week. If we have any feedback or suggestions, we'll add them back in the PR.

bigdatasourav · 2022-04-26T06:27:35Z

github/table_github_tree.go

+	return &plugin.Table{
+		Name:        "github_tree",
+		Description: "Tree in the given repository, lists files in the git tree",
+		Get: &plugin.GetConfig{


Could you please replace get with the list as below -

List: &plugin.ListConfig{ Hydrate: tableGitHubTreeGet, ShouldIgnoreError: isNotFoundError([]string{"404"}), KeyColumns: []*plugin.KeyColumn{ {Name: "repository_full_name", Require: plugin.Required}, {Name: "sha", Require: plugin.Required}, {Name: "recursive", Require: plugin.Optional}, }, },

bigdatasourav · 2022-04-26T06:28:47Z

github/table_github_tree.go

+	logger.Trace("Connecting to client")
+	client := connect(ctx, d)
+
+	if h.Item != nil {


Please remove this if-else block for hydrate data, as it is not required here.

bigdatasourav · 2022-04-26T06:29:28Z

github/table_github_tree.go

+	quals := d.KeyColumnQuals
+	logger.Trace("Parsing key column quals", quals)
+	fullName := quals["repository_full_name"].GetStringValue()
+	sha := quals["tree_sha"].GetStringValue()


Add a check for empty values like below -

// check if fullName and sha is empty if fullName == "" || sha == "" { return nil, nil }

bigdatasourav · 2022-04-26T06:30:08Z

github/table_github_tree.go

+	tree := getResp.tree
+	if tree != nil {
+		logger.Trace("Returning tree", tree)
+		return tree, nil


Suggested change

return tree, nil

d.StreamListItem(ctx, tree)

bigdatasourav · 2022-04-26T06:30:23Z

github/table_github_tree.go

+		logger.Trace("Returning tree", tree)
+		return tree, nil
+	}
+	logger.Error("Nothing found")


Suggested change

logger.Error("Nothing found")

bigdatasourav · 2022-04-26T06:30:38Z

github/table_github_tree.go

+	getResp := getResponse.(GetResponse)
+	tree := getResp.tree
+	if tree != nil {
+		logger.Trace("Returning tree", tree)


Suggested change

logger.Trace("Returning tree", tree)

bigdatasourav · 2022-04-26T06:49:01Z

github/table_github_tree.go

+		Columns: []*plugin.Column{
+			// Top columns
+			{Name: "repository_full_name", Type: proto.ColumnType_STRING, Transform: transform.FromQual("repository_full_name"), Description: "Full name of the repository"},
+			{Name: "tree_sha", Type: proto.ColumnType_STRING, Transform: transform.FromQual("tree_sha"), Description: "Tree SHA"},


Suggested change

{Name: "tree_sha", Type: proto.ColumnType_STRING, Transform: transform.FromQual("tree_sha"), Description: "Tree SHA"},

{Name: "sha", Type: proto.ColumnType_STRING, Transform: transform.FromQual("sha"), Description: "Tree SHA"},

bigdatasourav · 2022-04-26T06:49:15Z

github/table_github_tree.go

+	quals := d.KeyColumnQuals
+	logger.Trace("Parsing key column quals", quals)
+	fullName := quals["repository_full_name"].GetStringValue()
+	sha := quals["tree_sha"].GetStringValue()


Suggested change

sha := quals["tree_sha"].GetStringValue()

sha := quals["sha"].GetStringValue()

bigdatasourav · 2022-04-26T06:51:44Z

@asfaltboy Hope you are doing good!
While reviewing the PR I have suggested some changes. Also, there are merge conflicts which need to resolve.

Additionally, add a doc file (github_tree.md), example.

Please let us know if you need any help.

bigdatasourav · 2022-05-12T05:39:53Z

Hey @asfaltboy, please let us know if you have any questions or need any help with this PR, as we’d love to get your table in!

github-actions · 2022-07-11T23:33:29Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions · 2022-08-11T23:34:14Z

This PR was closed because it has been stalled for 90 days with no activity.

github-actions · 2022-09-11T23:35:48Z

'This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

asfaltboy added 2 commits January 29, 2022 16:05

Add github_tree - list files in the repository

4b66a3c

Add optional recursive key

22f3d45

github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 21, 2022

asfaltboy closed this Apr 22, 2022

cbruno10 reopened this Apr 22, 2022

cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 22, 2022

rajlearner17 requested a review from bigdatasourav April 25, 2022 05:16

bigdatasourav reviewed Apr 26, 2022

View reviewed changes

github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Jul 11, 2022

cbruno10 changed the base branch from main to add-github-tree-table July 12, 2022 12:22

cbruno10 changed the base branch from add-github-tree-table to main July 12, 2022 12:22

github-actions bot closed this Aug 11, 2022

cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Aug 12, 2022

cbruno10 reopened this Aug 12, 2022

github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Sep 11, 2022

Merge branch 'main' into github_tree

a73448f

cbruno10 marked this pull request as ready for review September 19, 2022 19:53

cbruno10 changed the base branch from main to add-github-tree-table September 19, 2022 19:53

cbruno10 changed the base branch from add-github-tree-table to main September 19, 2022 19:53

cbruno10 changed the base branch from main to add-github-tree-table September 19, 2022 19:58

cbruno10 approved these changes Sep 19, 2022

View reviewed changes

cbruno10 merged commit b5fa7f3 into turbot:add-github-tree-table Sep 19, 2022

cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub tree #133

GitHub tree #133

asfaltboy commented Jan 29, 2022

github-actions bot commented Apr 21, 2022

cbruno10 commented Apr 22, 2022

bigdatasourav Apr 26, 2022 •

edited

Loading

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav Apr 26, 2022

bigdatasourav commented Apr 26, 2022

bigdatasourav commented May 12, 2022 •

edited

Loading

github-actions bot commented Jul 11, 2022

github-actions bot commented Aug 11, 2022

github-actions bot commented Sep 11, 2022

	{Name: "tree_sha", Type: proto.ColumnType_STRING, Transform: transform.FromQual("tree_sha"), Description: "Tree SHA"},
	{Name: "sha", Type: proto.ColumnType_STRING, Transform: transform.FromQual("sha"), Description: "Tree SHA"},

	sha := quals["tree_sha"].GetStringValue()
	sha := quals["sha"].GetStringValue()

GitHub tree #133

GitHub tree #133

Conversation

asfaltboy commented Jan 29, 2022

Example query results

github-actions bot commented Apr 21, 2022

cbruno10 commented Apr 22, 2022

bigdatasourav Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav Apr 26, 2022

Choose a reason for hiding this comment

bigdatasourav commented Apr 26, 2022

bigdatasourav commented May 12, 2022 • edited Loading

github-actions bot commented Jul 11, 2022

github-actions bot commented Aug 11, 2022

github-actions bot commented Sep 11, 2022

bigdatasourav Apr 26, 2022 •

edited

Loading

bigdatasourav commented May 12, 2022 •

edited

Loading