Table headers for numeric columns are not right-aligned like the row-level cell content. Fixes #755. #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichaelBurgess
commented
Apr 3, 2025
MichaelBurgess
commented
…level cell content. Fixes #755.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where table headers for numeric columns were not right-aligned like the row-level cell content.
- Adjusted header padding from unilateral left padding ("pl-4") to symmetric horizontal padding ("px-4").
- Added a conditional CSS class to apply right alignment for numeric columns.
Comments suppressed due to low confidence (1)
ui/dashboard/src/components/dashboards/Table/index.tsx:1033
- Changing from 'pl-4' to 'px-4' adds symmetric padding, which may result in unintended spacing differences compared to row cells; please verify that this change maintains visual consistency across the table.
"py-3 font-normal tracking-wider whitespace-nowrap px-4",
cbruno10
approved these changes
Apr 3, 2025
MichaelBurgess
deleted the
issue-755-dashboard-table-numeric-column-align
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.