Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF #90

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF #90

wants to merge 9 commits into from

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Nov 21, 2021 •
edited
Loading

Fixes #89 (CI doesn't show it till we fix some unrelated things, but running the test locally does)

The [research needed] commit is unrelated to #89 and looks like it will be annoying to figure out.

jnm2
jnm2 commented Nov 21, 2021
View reviewed changes
...VisionLabs.ReferenceAssemblyAnnotator/EquivalenceComparers+ArrayDimensionEqualityComparer.cs
Comment on lines +19 to 20
#pragma warning disable CS8614 // In CLI builds: Nullability of reference types in type of parameter 'x' of 'bool ArrayDimensionEqualityComparer.Equals(ArrayDimension x, ArrayDimension y)' doesn't match implicitly implemented member 'bool IEqualityComparer<ArrayDimension>.Equals(ArrayDimension x, ArrayDimension y)'.
public bool Equals(ArrayDimension x, ArrayDimension y)
Copy link
Contributor Author

@jnm2 jnm2 Nov 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell ArrayDimension is a struct coming from the Mono.Cecil package. This issue doesn't repro unless RAA is rewriting reference assemblies.

Not sure if this is an existing RAA problem when used normally or whether it's a regression introduced in this PR.

@jnm2 jnm2 changed the title Test using the .NET 6 SDK Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF Nov 21, 2021
@jnm2
Copy link
Contributor Author

jnm2 commented Nov 21, 2021

This build failure is surprising, will have to come back and look closer when I have time to guess at what caused it.

dotnet msbuild -restore tests/NoDisabledWarnings -warnaserror -nr:false -v:m
Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
  Determining projects to restore...
  Restored C:\projects\referenceassemblyannotator\tests\NoDisabledWarnings\NoDisabledWarnings.csproj (in 6.57 sec).
C:\projects\referenceassemblyannotator\tests\.isolatednugetcache\tunnelvisionlabs.referenceassemblyannotator\1.0.0-alpha.172.ga01117b533\build\TunnelVisionLabs.ReferenceAssemblyAnnotator.targets(123,5): error RA1000: Skipping mixed-mode implementation assembly 'System.Data, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' [C:\projects\referenceassemblyannotator\tests\NoDisabledWarnings\NoDisabledWarnings.csproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jnm2