Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullReferenceException when NoWarn is empty #77

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Fix NullReferenceException when NoWarn is empty #77

merged 3 commits into from
Jan 3, 2020

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Jan 3, 2020

Fixes #76

@jnm2 jnm2 mentioned this pull request Jan 3, 2020
Merged
@jnm2 jnm2 marked this pull request as ready for review January 3, 2020 04:12
sharwell
sharwell reviewed Jan 3, 2020
View reviewed changes
appveyor.yml Outdated Show resolved Hide resolved
@jnm2 @sharwell
Try TreatWarningsAsErrors=true
f0fdd79 
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@sharwell sharwell merged commit 7c75c5d into tunnelvisionlabs:master Jan 3, 2020
@jnm2 jnm2 deleted the null_disabledwarnings branch January 3, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NRE in SuppressibleLoggingHelper constructor
2 participants
@jnm2 @sharwell