-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #54 from jnm2/faster_resolver
Use stripped-down resolver for perf (no GAC, deferred reading mode)
- Loading branch information
Showing
5 changed files
with
109 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{ | ||
"profiles": { | ||
"mscorlib": { | ||
"Microsoft.Win32.Primitives (netstandard1.6)": { | ||
"commandName": "Project", | ||
"commandLineArgs": "\"$(NuGetPackageRoot)\\microsoft.netframework.referenceassemblies.net45\\1.0.0-preview.2\\build\\.NETFramework\\v4.5\\mscorlib.dll\" \"$(NuGetPackageRoot)\\microsoft.netcore.app.ref\\3.0.0-preview8-28405-07\\ref\\netcoreapp3.0\\mscorlib.dll\" mscorlib2.dll" | ||
"commandLineArgs": "\"$(NuGetPackageRoot)\\microsoft.win32.primitives\\4.3.0\\ref\\netstandard1.3\\Microsoft.Win32.Primitives.dll\" \"$(NuGetPackageRoot)\\microsoft.win32.primitives\\4.3.0\\ref\\netstandard1.3\\;$(NuGetPackageRoot)\\system.runtime\\4.3.0\\ref\\netstandard1.5\\\\\" \"$(NuGetPackageRoot)\\microsoft.netcore.app.ref\\3.0.0\\ref\\netcoreapp3.0\\Microsoft.Win32.Primitives.dll\" Microsoft.Win32.Primitives.dll" | ||
}, | ||
"System": { | ||
"System.ComponentModel.DataAnnotations (netcoreapp2.0)": { | ||
"commandName": "Project", | ||
"commandLineArgs": "\"$(NuGetPackageRoot)\\microsoft.netframework.referenceassemblies.net45\\1.0.0-preview.2\\build\\.NETFramework\\v4.5\\System.dll\" \"$(NuGetPackageRoot)\\microsoft.netcore.app.ref\\3.0.0-preview8-28405-07\\ref\\netcoreapp3.0\\System.dll\" System2.dll" | ||
"commandLineArgs": "\"$(NuGetPackageRoot)\\microsoft.netcore.app\\2.0.0\\ref\\netcoreapp2.0\\System.ComponentModel.DataAnnotations.dll\" \"$(NuGetPackageRoot)\\microsoft.netcore.app\\2.0.0\\ref\\netcoreapp2.0\\\\\" \"$(NuGetPackageRoot)\\microsoft.netcore.app.ref\\3.0.0\\ref\\netcoreapp3.0\\System.ComponentModel.DataAnnotations.dll\" System.ComponentModel.DataAnnotations.dll" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
TunnelVisionLabs.ReferenceAssemblyAnnotator/AssemblyResolver.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved. | ||
// Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
||
namespace TunnelVisionLabs.ReferenceAssemblyAnnotator | ||
{ | ||
using System.Collections.Generic; | ||
using System.Collections.Immutable; | ||
using System.IO; | ||
using System.Linq; | ||
using Mono.Cecil; | ||
|
||
internal sealed class AssemblyResolver : IAssemblyResolver | ||
{ | ||
private static readonly ReaderParameters DefaultReaderParameters = new ReaderParameters(ReadingMode.Deferred); | ||
|
||
private readonly ImmutableArray<string> _searchDirectories; | ||
private readonly Dictionary<string, AssemblyDefinition?> _assembliesByFileName = new Dictionary<string, AssemblyDefinition?>(); | ||
|
||
public AssemblyResolver(ImmutableArray<string> searchDirectories) | ||
{ | ||
_searchDirectories = searchDirectories; | ||
} | ||
|
||
public AssemblyDefinition? Resolve(AssemblyNameReference name) | ||
{ | ||
return Resolve(name, DefaultReaderParameters); | ||
} | ||
|
||
public AssemblyDefinition? Resolve(AssemblyNameReference name, ReaderParameters parameters) | ||
{ | ||
if (!_assembliesByFileName.TryGetValue(name.Name, out var assembly)) | ||
{ | ||
var stream = _searchDirectories | ||
.Select(directory => OpenReadIfExists(Path.Combine(directory, name.Name + ".dll"))) | ||
.FirstOrDefault(s => s is object); | ||
|
||
assembly = stream is null ? null : AssemblyDefinition.ReadAssembly(stream, parameters); | ||
|
||
_assembliesByFileName.Add(name.Name, assembly); | ||
} | ||
|
||
return assembly is object && Matches(assembly.Name, name) ? assembly : null; | ||
} | ||
|
||
private static FileStream? OpenReadIfExists(string path) | ||
{ | ||
try | ||
{ | ||
return File.OpenRead(path); | ||
} | ||
catch (FileNotFoundException) | ||
{ | ||
return null; | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// The point of this method is to be a high-performance sanity check, not to reproduce .NET assembly loading | ||
/// behavior. | ||
/// </summary> | ||
private static bool Matches(AssemblyNameDefinition definition, AssemblyNameReference reference) | ||
{ | ||
return definition.Name == reference.Name | ||
&& definition.Version >= reference.Version; | ||
} | ||
|
||
public void Dispose() | ||
{ | ||
foreach (var loadedAssembly in _assembliesByFileName.Values) | ||
{ | ||
loadedAssembly?.Dispose(); | ||
} | ||
|
||
_assembliesByFileName.Clear(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters