-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix(): Add support for list of expressions as default value #111
Conversation
(a = (doSomething(), doSomethingElse(), true)) => {} is a prefectly valid syntax that is used
extensively by code instrumenters. When a list of expressions is used as a default value, only the
last expression is the actual default value. This commit add support for this syntax.
TAG: latest
fixes tunnckoCore#110
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 90 96 +6
=====================================
+ Hits 90 96 +6
Continue to review full report at Codecov.
|
|
Great! ❤️ Thanks, I'll merge soon. But just should recheck what's up with the new-release GitHub App. Probably moved to frozen state... |
|
Hoping refreshed |
|
Yeaaah!! 🎉 And there it go :) 💯 https://github.com/tunnckoCore/parse-function/releases/tag/v5.1.0
|
|
I think you broke something :D There is no dist/index.js in the final package. Only dist/test.js. |
|
damn.. :D probably.. |
|
Yup. Should work now. 🥇 |
|
Awesome! 👍 I just built Twing using parse-function 5.1.1, removing my custom code that worked around instrumentation problem, and it's perfect. Thanks a lot! |
|
Sweeet :) It's big pleasure to develop with such workflow 💃 |
|
Just to notify that it includes dist from https://github.com/tunnckoCore/parse-function/releases/tag/v5.2.1 and won't have such problems in future. :)
|
I didn't add a plugin. I think it makes more sense to improve the existing plugin that deals with params since the scope of this change is the params and nothing else.
Tests were added and code coverage preserved.