Skip to content

Show and apply provider handle suffix in sign-in - #1242

Open
HI-JIN2 wants to merge 3 commits into
mainfrom
jin/add-suffix-signin
Open

Show and apply provider handle suffix in sign-in#1242
HI-JIN2 wants to merge 3 commits into
mainfrom
jin/add-suffix-signin

Conversation

@HI-JIN2

@HI-JIN2 HI-JIN2 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Screen_recording_20260422_212746.webm

@HI-JIN2
HI-JIN2 requested a review from tunjid April 22, 2026 12:31
@HI-JIN2 HI-JIN2 self-assigned this Apr 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a dynamic handle suffix in the sign-in screen, allowing users to enter handles without explicit domains which are then normalized based on the selected server. Validation logic was updated to support this new behavior. A review comment suggests improving the domain extraction logic from server endpoints to more robustly handle potential trailing slashes.

Comment thread feature/auth/src/commonMain/kotlin/com/tunjid/heron/signin/State.kt Outdated
@tunjid

tunjid commented Apr 23, 2026

Copy link
Copy Markdown
Owner

Thanks so much for this! I'm still reviewing, sorry its a bit slow. I'm taking my time bc it affects all users of the app when signing in. Any bugs could mean sign out is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-append provider domain for username-only login input

2 participants