Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker rediscovery with config.brokers parameter taking callback function #854
Broker rediscovery with config.brokers parameter taking callback function #854
Changes from 16 commits
b41cb5b
6222313
a4ef35b
b3fc1c9
ccfdd7c
23b0df8
f9c57f9
b02d81d
ae99e5b
917152d
ecdb139
02f7e15
017e5ed
3f073c5
bc2243b
c93e6e6
ba3b325
ceed1af
93afdca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be a
KafkaJSConnectionError
, since it's actually a validation error that's not retriable unless the data it's validating changes.KafkaJSConnectionError
is retriable. I see three options:validateBrokers
a bit smarter and have it throw a retriable error ifbrokers
is a function and a non-retriable error if it's not.brokers
in an async function that does retrying internally instead. Something along the lines ofThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest second option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!