Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fall-back retry config for producer #851

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

pawelrychlik
Copy link
Contributor

See https://github.com/tulios/kafkajs/blob/master/src/producer/index.js#L56
this.retry in cluster constructor was not assigned, so referring to cluster.retry from producer constructor will always yield undefined.

See https://github.com/tulios/kafkajs/blob/master/src/producer/index.js#L56
`this.retry` in cluster constructor was not assigned, so referring to `cluster.retry` from producer constructor will always yield undefined.
@Nevon
Copy link
Collaborator

Nevon commented Aug 31, 2020

Thanks for the fix.

@Nevon Nevon merged commit 5987f27 into tulios:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants