Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the options for the runner constructor #843

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Define the options for the runner constructor #843

merged 3 commits into from
Aug 20, 2020

Commits on Aug 19, 2020

  1. Define the options for the runner constructor

    @ankon
    ankon committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    57b70c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. squash: Refine the type for onCrash further 

    * Drop the return value: We don't do anything with it anyways, so the provider of that
  handler shouldn't make any assumptions
* Refine the `reason` parameter to always be an 'Error' instance, and accept the minimal
  risk that some downstream library does stupid things
* Make the `onCrash` property non-optional, as we do refer to ith without a guard
    @ankon
    ankon committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    f5ee8f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/runner-constructor-option-types

    @Nevon
    Nevon authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a42820b View commit details
    Browse the repository at this point in the history