Add JoinGroup protocol v3 and v4 #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
reviewed
Jul 24, 2020
Nevon
reviewed
Jul 24, 2020
Nevon
reviewed
Jul 24, 2020
Nevon
reviewed
Jul 24, 2020
Nevon
reviewed
Jul 24, 2020
Nevon
requested changes
Jul 24, 2020
goriunov
commented
Jul 25, 2020
Nevon
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add protocol support for JoinGroup v3 and v4, based on https://cwiki.apache.org/confluence/display/KAFKA/KIP-394%3A+Require+member.id+for+initial+join+group+request v4 protocol we need to retry join with provided member id if we get MEMBER_ID_REQUIRED