Use addMultipleTargetTopics instead of looping over multiple calls to addTargetTopic #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addTargetTopic addTargetTopic internally calls addMultipleTargetTopics by building a singular array anyways, and addMultipleTargetTopics itself is fairly expensive and requires locking: Simply calling it directly should make things faster when sending out batches for multiple topics.
|
Nice catch! Could you merge master and we'll get this merged. Btw, when you create a fork, you can allow maintainers of the forked repo to push to the PR branch, which would allow us to press the nice "update with latest master" button in the PR UI instead of having to bug you. |
Nevon
approved these changes
Jun 11, 2020
|
Done. I'll have a look for that setting, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addTargetTopicinternally callsaddMultipleTargetTopicsby building a singular array anyways, andaddMultipleTargetTopicsitself is fairly expensive and requires locking: Simply callingit directly should make things faster when sending out batches for multiple topics.
This should help when batch-producing messages to multiple topics at the same time. Looking at the produce path it seems there could be quite some additional potential for "improvements", but it is difficult to quantify how much all of that would help.