Add listTopics to Admin #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Nevon
requested changes
May 7, 2020
| /** | ||
| * @return {Promise} | ||
| */ | ||
| const listTopics = async () => { |
There was a problem hiding this comment.
Could you please add a test for this change as well?
Nevon
requested changes
May 7, 2020
src/admin/index.js
Outdated
| * @return {Promise} | ||
| */ | ||
| const listTopics = async () => { | ||
| await cluster.refreshMetadata() |
There was a problem hiding this comment.
This should not be necessary. cluster.metadata will refresh if it needs to. refreshMetadata will also just refresh metadata for topics it knows about, so it wouldn't be able to discover new topics anyway.
Nevon
requested changes
May 7, 2020
src/admin/index.js
Outdated
| */ | ||
| const listTopics = async () => { | ||
| await cluster.refreshMetadata() | ||
| const { topicMetadata } = await cluster.metadata({ topics: [] }) |
There was a problem hiding this comment.
{ topics: []} is already the default behavior for cluster.metadata, so no need to pass it in.
Nevon
approved these changes
May 8, 2020
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.