-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin.describeCluster #648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns metadata for all brokers in the cluster. Fixes #647
JaapRood
reviewed
Mar 3, 2020
This reverts commit 0a96054.
…to admin-describe-cluster
JaapRood
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Comment on lines
+189
to
+190
Allows you to get information about the broker cluster. This is mostly useful | ||
for monitoring or operations, and is usually not relevant for typical event processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short and sweet way to prevent a whole bunch of confusion, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns metadata for all brokers in the cluster.
The API is roughly based on the Java
Admin.describeCluster
API. The big differences are:brokers
property instead ofnodes
. The id is still called anodeId
, but I don't think we really use theNode
terminology anywhere, so I went withbrokers
instead.AuthorizedOperations
that can be optionally included. I didn't add it as the current use-case doesn't need it, and I haven't actually looked into what it is or why you'd want it.Usage is simply:
await admin.describeCluster()
and returns:Fixes #647